Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for deploying/verifying/checking contracts issued using factories #132

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Add functionality for deploying/verifying/checking contracts issued using factories #132

merged 13 commits into from
Dec 13, 2024
+424 −23

Conversation

elshan-eth
Copy link
Contributor

@elshan-eth elshan-eth commented Dec 5, 2024 •
edited
Loading

Description

This PR adds functions for deploying and verifying contracts using factories.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@elshan-eth elshan-eth changed the title Add functionality for deploying/verifying/checking contracts issued using the factory DRAFT: Add functionality for deploying/verifying/checking contracts issued using the factory Dec 5, 2024
jubeira
jubeira reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach! I think it makes sense. Just one observation regarding contract verification: we should be able to run the scripts live more than once.

We should skip deployment if there are existing outputs for the contract, but verification should always be executed in live mode.

@elshan-eth elshan-eth changed the title DRAFT: Add functionality for deploying/verifying/checking contracts issued using the factory Add functionality for deploying/verifying/checking contracts issued using a factory Dec 6, 2024
@elshan-eth elshan-eth changed the title Add functionality for deploying/verifying/checking contracts issued using a factory Add functionality for deploying/verifying/checking contracts issued using factories Dec 6, 2024
@elshan-eth elshan-eth marked this pull request as ready for review December 6, 2024 14:53
@elshan-eth elshan-eth requested a review from jubeira December 6, 2024 14:59
jubeira
jubeira approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @elshan-eth !

Just tried redeploying the vault to sepolia with different settings and worked pretty well. Great job!

@jubeira jubeira merged commit e438df9 into master Dec 13, 2024
30 checks passed
@jubeira jubeira deleted the add-deploy-functions-for-factory branch December 13, 2024 20:48
@jubeira jubeira mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubeira jubeira jubeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elshan-eth @jubeira